Re: [Qemu-devel] [PATCH v7 6/6] fsdev: QMP interface for throttling

[Markus Armbruster]

Pradeep Jagadeesh <address@hidden> writes:

> On 7/6/2017 8:47 PM, Markus Armbruster wrote:
>> Pradeep Jagadeesh <address@hidden> writes:
>>
>>> This patch introduces qmp interfaces for the fsdev
>>> devices. This provides two interfaces one
>>> for querying info of all the fsdev devices. The second one
>>> to set the IO limits for the required fsdev device.
>>>
>>> Signed-off-by: Pradeep Jagadeesh <address@hidden>
>>> ---
>>>  Makefile                    |  4 +++
>>>  fsdev/qemu-fsdev-dummy.c    | 10 ++++++
>>>  fsdev/qemu-fsdev-throttle.c | 76 +++++++++++++++++++++++++++++++++++++++-
>>>  fsdev/qemu-fsdev-throttle.h | 13 +++++++
>>>  fsdev/qemu-fsdev.c          | 37 ++++++++++++++++++++
>>>  monitor.c                   |  5 +++
>>>  qapi-schema.json            |  3 ++
>>>  qapi/fsdev.json             | 84 
>>> +++++++++++++++++++++++++++++++++++++++++++++
>>>  qmp.c                       | 14 ++++++++
>>>  9 files changed, 245 insertions(+), 1 deletion(-)
>>>  create mode 100644 qapi/fsdev.json
>>>
>>> diff --git a/Makefile b/Makefile
>>> index 16a0430..4fd7625 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -416,6 +416,10 @@ qapi-modules = $(SRC_PATH)/qapi-schema.json 
>>> $(SRC_PATH)/qapi/common.json \
>>>                 $(SRC_PATH)/qapi/crypto.json $(SRC_PATH)/qapi/rocker.json \
>>>                 $(SRC_PATH)/qapi/trace.json
>>>
>>> +ifdef CONFIG_VIRTFS
>>
>> Uh, qapi-schema.json includes fsdev.json *unconditionally*, doesn't it?
> Yes, I did not find any ways to include with some condition.

Hiding dependencies from Make is unlikely to help.  Please drop the
ifdef.

QAPI doesn't currently support conditional inclusion or any compile-time
conditionals for that matter.  Marc-André is trying to change that:
"[PATCH 00/26] qapi: add #if pre-processor conditions to generated
code".

[...]