[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver |
Date: |
Tue, 08 Aug 2017 17:04:48 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 08 Aug 2017 04:56:20 PM CEST, Manos Pitsidianakis wrote:
>>> So basically if we have anonymous groups, we accept limits in the
>>> driver options but only without a group-name.
>>
>>In the commit message you do however have limits and a group name, is
>>that a mistake?
>>
>> -drive driver=throttle,file.filename=foo.qcow2, \
>> limits.iops-total=...,throttle-group=bar
>
> Sorry this wasn't clear, I'm actually proposing to remove limits from
> the throttle driver options and only create/config throttle groups via
> -object/object-add.
Sorry I think it was me who misunderstood :-) Anyway in the new
command-line API I would be more inclined to have limits defined using
"-object throttle-group" and -drive would only reference the group id.
I understand that this implies that it wouldn't be possible to create
anonymous groups (at least not from the command line), is that a
problem?
Berto
- Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver, Stefan Hajnoczi, 2017/08/01
- Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver, Kevin Wolf, 2017/08/03
- Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver, Alberto Garcia, 2017/08/08
- Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver, Manos Pitsidianakis, 2017/08/08
- Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver, Alberto Garcia, 2017/08/08
- Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver, Manos Pitsidianakis, 2017/08/08
- Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver,
Alberto Garcia <=
- Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver, Manos Pitsidianakis, 2017/08/09
- Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver, Alberto Garcia, 2017/08/09
- Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver, Manos Pitsidianakis, 2017/08/09
- Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver, Alberto Garcia, 2017/08/09
- Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver, Kevin Wolf, 2017/08/09
- Re: [Qemu-devel] [PATCH v3 5/7] block: add throttle block filter driver, Manos Pitsidianakis, 2017/08/14