[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/13] vvfat: correctly generate numeric-tail
From: |
Pranith Kumar |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/13] vvfat: correctly generate numeric-tail of short file names |
Date: |
Tue, 8 Aug 2017 19:31:09 -0400 |
On Mon, Aug 7, 2017 at 7:07 AM, Eric Blake <address@hidden> wrote:
> On 08/05/2017 01:52 PM, Pranith Kumar wrote:
>> FYI,
>>
>> This commit breaks the build with gcc-7:
>>
>> CC block/vvfat.o
>> qemu/block/vvfat.c: In function ‘read_directory’:
>> qemu/block/vvfat.c:605:37: error: ‘__builtin___sprintf_chk’ may write
>> a terminating nul past the end of the destination
>> [-Werror=format-overflow=]
>> int len = sprintf(tail, "~%d", i);
>> ^~~~~
>
> Doesn't commit 7c8730d45f6 fix that?
Indeed it does. I hadn't rebased my branch before reporting. Sorry for
the noise!
--
Pranith