Re: [Qemu-devel] [PATCH v6 00/19] Multifd

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v6 00/19] Multifd
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
034b3874c1 migration: Flush receive queue
3fe0ff9b4c migration: Transfer pages over new channels
0e6fed07e3 migration: Rename initial_bytes
8e955cb1e9 migration: Test new fd infrastructure
540a3be741 migration: Create thread infrastructure for multifd recv side
b9c4545c48 migration: Send the fd number which we are going to use for this page
a792c56daf migration: Really use multiple pages at a time
06a2666427 migration: Create ram_multifd_page
b1fde6d03c migration: Start of multiple fd work
b3e2b1906a migration: Split migration_fd_process_incoming
ce2fe5d7db migration: Create multifd migration threads
f1f8bf78fc migration: Create x-multifd-group parameter
f5a3e44c18 migration: Create x-multifd-threads parameter
7b1d962ac0 migration: Add multifd capability
16b0261e18 qio: Create new qio_channel_{readv, writev}_all
62ad768837 migration: Create migration_has_all_channels
537e13fd36 migration: Add comments to channel functions
7639aeec12 migration: Teach it about G_SOURCE_REMOVE
317b84e0f0 migration: Create migration_ioc_process_incoming()

=== OUTPUT BEGIN ===
Checking PATCH 1/19: migration: Create migration_ioc_process_incoming()...
ERROR: trailing whitespace
#59: FILE: migration/migration.c:369:
+    $

total: 1 errors, 0 warnings, 72 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/19: migration: Teach it about G_SOURCE_REMOVE...
Checking PATCH 3/19: migration: Add comments to channel functions...
Checking PATCH 4/19: migration: Create migration_has_all_channels...
Checking PATCH 5/19: qio: Create new qio_channel_{readv, writev}_all...
Checking PATCH 6/19: migration: Add multifd capability...
Checking PATCH 7/19: migration: Create x-multifd-threads parameter...
Checking PATCH 8/19: migration: Create x-multifd-group parameter...
Checking PATCH 9/19: migration: Create multifd migration threads...
Checking PATCH 10/19: migration: Split migration_fd_process_incoming...
Checking PATCH 11/19: migration: Start of multiple fd work...
Checking PATCH 12/19: migration: Create ram_multifd_page...
Checking PATCH 13/19: migration: Really use multiple pages at a time...
Checking PATCH 14/19: migration: Send the fd number which we are going to use 
for this page...
Checking PATCH 15/19: migration: Create thread infrastructure for multifd recv 
side...
Checking PATCH 16/19: migration: Test new fd infrastructure...
Checking PATCH 17/19: migration: Rename initial_bytes...
Checking PATCH 18/19: migration: Transfer pages over new channels...
Checking PATCH 19/19: migration: Flush receive queue...
WARNING: line over 80 characters
#38: FILE: migration/ram.c:79:
+#define RAM_SAVE_FLAG_MULTIFD_SYNC (RAM_SAVE_FLAG_MULTIFD_PAGE | 
RAM_SAVE_FLAG_ZERO)

total: 0 errors, 1 warnings, 120 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden