Re: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
7c26de29e6 display: convert XenInput keyboard to keycodemapdb
b9d4f633bb ui: remove qemu_input_linux_to_qcode method
b82952e02a ui: remove qemu_input_qcode_to_number method
e61e51c4c6 ui: convert GTK and SDL1 frontends to keycodemapdb
8da0073fa4 ui: convert the SDL2 frontend to keycodemapdb
f4347fae8a ui: convert cocoa frontend to keycodemapdb
0bb5e3ca3a char: convert the escc device to keycodemapdb
1524c6518c input: convert the adb device to keycodemapdb
931965df01 input: convert ps2 device to keycodemapdb
0e01238d65 input: convert virtio-input-hid device to keycodemapdb
f6ca40df3d ui: use QKeyCode exclusively in InputKeyEvent
5252b5946a ui: don't export qemu_input_event_new_key
047c3a0c37 ui: convert key events to QKeyCodes immediately
9ee7d5824f ui: convert common input code to keycodemapdb
ae5a212c48 ui: add keycodemapdb repository as a GIT submodule

=== OUTPUT BEGIN ===
Checking PATCH 1/15: ui: add keycodemapdb repository as a GIT submodule...
Checking PATCH 2/15: ui: convert common input code to keycodemapdb...
Checking PATCH 3/15: ui: convert key events to QKeyCodes immediately...
Checking PATCH 4/15: ui: don't export qemu_input_event_new_key...
Checking PATCH 5/15: ui: use QKeyCode exclusively in InputKeyEvent...
WARNING: line over 80 characters
#361: FILE: ui/input.c:380:
+void qemu_input_event_send_key_qcode(QemuConsole *src, QKeyCode qcode, bool 
down)

total: 0 errors, 1 warnings, 321 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/15: input: convert virtio-input-hid device to keycodemapdb...
Checking PATCH 7/15: input: convert ps2 device to keycodemapdb...
Checking PATCH 8/15: input: convert the adb device to keycodemapdb...
Checking PATCH 9/15: char: convert the escc device to keycodemapdb...
Checking PATCH 10/15: ui: convert cocoa frontend to keycodemapdb...
Checking PATCH 11/15: ui: convert the SDL2 frontend to keycodemapdb...
WARNING: line over 80 characters
#101: FILE: ui/sdl2-input.c:40:
+    for (i = 0; i < SDL_NUM_SCANCODES && i < qemu_input_map_usb2qcode_len ; 
i++) {

total: 0 errors, 1 warnings, 56 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/15: ui: convert GTK and SDL1 frontends to keycodemapdb...
ERROR: unnecessary whitespace before a quoted newline
#279: FILE: ui/gtk.c:1149:
+        g_warning("experimental: using broadway, x11 virtual keysym \n"

ERROR: unnecessary whitespace before a quoted newline
#280: FILE: ui/gtk.c:1150:
+                  "mapping - with very limited support. See also \n"

ERROR: braces {} are necessary for all arms of this statement
#301: FILE: ui/gtk.c:1170:
+    if (!keycode_map)
[...]

ERROR: braces {} are necessary for all arms of this statement
#303: FILE: ui/gtk.c:1172:
+    if (scancode > keycode_maplen)
[...]

ERROR: braces {} are necessary for all arms of this statement
#550: FILE: ui/sdl.c:245:
+    if (!keycode_map)
[...]

ERROR: braces {} are necessary for all arms of this statement
#552: FILE: ui/sdl.c:247:
+    if (ev->keysym.scancode > keycode_maplen)
[...]

ERROR: braces {} are necessary for all arms of this statement
#797: FILE: ui/x_keymap.c:27:
+    if (strstr(vendor, "Cygwin/X"))
[...]

ERROR: braces {} are necessary for all arms of this statement
#813: FILE: ui/x_keymap.c:41:
+        if (strcmp(extensions[i], "Apple-WM") == 0 ||
[...]

ERROR: braces {} are necessary for all arms of this statement
#817: FILE: ui/x_keymap.c:45:
+    if (extensions)
[...]

total: 9 errors, 0 warnings, 833 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 13/15: ui: remove qemu_input_qcode_to_number method...
Checking PATCH 14/15: ui: remove qemu_input_linux_to_qcode method...
Checking PATCH 15/15: display: convert XenInput keyboard to keycodemapdb...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden