Re: [Qemu-devel] [PATCH RFC 0/5] target/s390x: introduce internal.h and cleanup cpu.h

[David Hildenbrand]

On 11.08.2017 17:15, Cornelia Huck wrote:
> On Fri, 11 Aug 2017 09:46:47 +0200
> David Hildenbrand <address@hidden> wrote:
> 
>> cpu.h is accessed outside of target/s390x. It should only contain
>> what is expected to be accessed outside of this folder. Therefore, create
>> internal.h and move a lot to that file.
> 
> Cool, I like that.
> 
>>
>> While doing that, I noticed that a lot of function prototypes not
>> available with CONFIG_USER_ONLY are not protected by CONFIG_USER_ONLY.
>>
>> As these CONFIG_USER_ONLY are in general ugly, I decided to minimize
>> them to the bare minimum :]. Do we care? I dropped it wherever possible.
>>
>> My compiler doesn't bail out, so let's see what the bot says.
> 
> That should be easy to fix :)
> 
>>
>> There is still a lot to clean up (e.g. do we want kvm-stub.c ?). This is
>> the first step.
> 
> Do you plan to send a v2 with kvm_s390x.h? If yes, I'll hold off
> looking at this series.
> 

Yes, will take care of the review comments from Richard and Thomas.
(including kvm_s390x.h)

-- 

Thanks,

David