Re: [Qemu-devel] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C emulation from ppc405_uc to its own file

[Paolo Bonzini]

On 14/08/2017 13:18, BALATON Zoltan wrote:
> On Mon, 14 Aug 2017, Paolo Bonzini wrote:
>> On 13/08/2017 19:04, BALATON Zoltan wrote:
>>> Signed-off-by: BALATON Zoltan <address@hidden>
>>> ---
>>>  hw/ppc/Makefile.objs |   2 +-
>>>  hw/ppc/ppc405.h      |   2 +
>>>  hw/ppc/ppc405_uc.c   | 241
>>> ---------------------------------------------
>>>  hw/ppc/ppc4xx_i2c.c  | 272
>>> +++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  4 files changed, 275 insertions(+), 242 deletions(-)
>>>  create mode 100644 hw/ppc/ppc4xx_i2c.c
>>
>> Can you move it to hw/i2c while you're at it?
> 
> I could if that's the preferred way but I've left it in hw/ppc because
> this is not a generic device but specific to PPC SoCs and it was easier
> to work with files in one dir than scattered through the tree. Should I
> still move it to hw/i2c?

Please do, having devices in hw/* helps when you do all-tree cleanups.

Paolo