qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] bios-tables-test: use strlen instead of sizeof


From: wei . yang
Subject: [Qemu-devel] [PATCH] bios-tables-test: use strlen instead of sizeof
Date: Tue, 15 Aug 2017 13:04:14 +0800

From: Wei Yang <address@hidden>

sizeof(BLOCK_NAME_END) is actually 2.  it can work
because there's a space after ,. but It is better to
replace it with strlen so it will work without a space too.

Signed-off-by: Wei Yang <address@hidden>
CC: Michael S. Tsirkin <address@hidden>
CC: address@hidden
---
 tests/bios-tables-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index 88dbf97853..d1f31b19d3 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -352,7 +352,7 @@ static GString *normalize_asl(gchar *asl_code)
         block_name = g_strstr_len(asl->str, asl->len, BLOCK_NAME_END);
         g_assert(block_name);
         asl = g_string_erase(asl, 0,
-                             block_name + sizeof(BLOCK_NAME_END) - asl->str);
+                             block_name + strlen(BLOCK_NAME_END) - asl->str);
     }
 
     return asl;
-- 
2.11.0





reply via email to

[Prev in Thread] Current Thread [Next in Thread]