Re: [Qemu-devel] [PATCH 1/2] block: use internal filter node in backup

[Manos Pitsidianakis]

On Tue, Aug 15, 2017 at 10:44:15AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 15.08.2017 09:19, Manos Pitsidianakis wrote:
> > block/backup.c currently uses before write notifiers on the targeted
> > node. We can create a filter node instead to intercept write requests
> > for the backup job on the BDS level, instead of the BlockBackend level.
>
> Hi Manos!
>
> Looks interesting but what is the real benefit of it? It doesn't look 
> like it simplifies the code.. Also, is it affect performance?
> I think it worth describing in commit message.

The goal is to refactor the block layer into being more modular instead 
of having hard coded features. I don't suspect this will have any kind 
of performance gains, this is a minor change. Before write notifiers are 
not needed if you can intercept the write requests on the way.

signature.asc
Description: PGP signature