[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10 v2 2/4] nbd: Fix order of bdrv_set_perm
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.10 v2 2/4] nbd: Fix order of bdrv_set_perm and bdrv_invalidate_cache |
Date: |
Tue, 15 Aug 2017 09:16:20 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/15/2017 08:07 AM, Fam Zheng wrote:
> From: Kevin Wolf <address@hidden>
>
> The "inactive" state of BDS affects whether the permissions can be
> granted, we must call bdrv_invalidate_cache before bdrv_set_perm to
> support "-incoming defer" case.
>
> Reported-by: Christian Ehrhardt <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> nbd/server.c | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/nbd/server.c b/nbd/server.c
> index 82a78bf439..b68b6fb535 100644
> --- a/nbd/server.c
> +++ b/nbd/server.c
> @@ -1045,11 +1045,22 @@ NBDExport *nbd_export_new(BlockDriverState *bs, off_t
> dev_offset, off_t size,
> bool writethrough, BlockBackend *on_eject_blk,
> Error **errp)
> {
> + AioContext *ctx;
Odd spacing; can fix up as maintainer.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH for-2.10 v2 0/4] block: Fix non-shared storage migration, Fam Zheng, 2017/08/15
- [Qemu-devel] [PATCH for-2.10 v2 1/4] stubs: Add vm state change handler stubs, Fam Zheng, 2017/08/15
- [Qemu-devel] [PATCH for-2.10 v2 2/4] nbd: Fix order of bdrv_set_perm and bdrv_invalidate_cache, Fam Zheng, 2017/08/15
- Re: [Qemu-devel] [PATCH for-2.10 v2 2/4] nbd: Fix order of bdrv_set_perm and bdrv_invalidate_cache,
Eric Blake <=
- [Qemu-devel] [PATCH for-2.10 v2 3/4] block-backend: Defer shared_perm tightening migration completion, Fam Zheng, 2017/08/15
- [Qemu-devel] [PATCH for-2.10 v2 4/4] iotests: Add non-shared storage migration case 192, Fam Zheng, 2017/08/15
- Re: [Qemu-devel] [PATCH for-2.10 v2 0/4] block: Fix non-shared storage migration, Christian Ehrhardt, 2017/08/18