Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

[Philippe Mathieu-Daudé]

On 08/15/2017 03:39 PM, Peter Maydell wrote:
> On 15 August 2017 at 19:27, Philippe Mathieu-Daudé <address@hidden> wrote:
> > On 08/15/2017 03:13 PM, Eric Blake wrote:
> > > On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote:
> > > > only warn once about it.
> > > >
> > > > - kernel without kvm:
> > > >
> > > >       # make check-qtest-x86_64
> > > >         GTESTER check-qtest-x86_64
> > > >       Could not access KVM kernel module: No such device
> > > >       qemu-system-x86_64: failed to initialize KVM: No such device
> > > >       qemu-system-x86_64: Back to tcg accelerator
> > >
> > >
> > > How does this differ from what commit 2f6b38d1 was trying to do?
> >
> >
> > I'd say 2f6b38d1 is for common end-user usage while this is for QA/testers
> > usage. If you run N qtests with the same machine arguments, having this
> > warning displayed only once is enough and allow you to focus on the tests
> > output.
>
> I think I'd rather we just straightforwardly didn't complain at
> all in the 'make check' output. There's no benefit to this
> for all these tests, especially given that they pretty much
> don't care whether they run under KVM or TCG because they're

Oh you mean checking qtest_enabled() within configure_accelerator()? Ok, 
clever :)

> not trying to test that. (If they *are* trying to test KVM
> specific functionality then they should either skip the
> test quietly if KVM isn't present or they should fail it;
> printing useless waffle to the logs isn't helpful IMHO.)
>
> thanks
> -- PMM