[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/3] qmp: introduce query-memory-size-summary
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 2/3] qmp: introduce query-memory-size-summary command |
|
Date: |
Wed, 16 Aug 2017 08:01:11 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Vadim Galitsyn <address@hidden> writes:
> Hi Guys,
>
> Thank you for the input!
>
>> "hotunpluggable" is ugly. What about just "pluggable"?
>
> Markus, I think "pluggable" is a bit misleading here. Some people can take
> it like a maximum amount of memory that can be hot-added to a guest (i.e.,
> difference between static memory size and value specified with "-m
> ...,maxmem=XXX"). I would say:
>
> mem_info->plugged_memory = get_plugged_memory_size();
>
> ..since it reflects actual amount which was already hot-added. Agree?
I like it. Thanks!
[...]