[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerat
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator |
Date: |
Wed, 16 Aug 2017 10:28:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 16/08/2017 10:26, Cornelia Huck wrote:
> Prefer to use the tcg accelarator if it is available: This is our only
> real smoke test for tcg, and fast enough to use it for that.
>
> Fixes: 480bc11e6 ("boot-serial-test: fallback to kvm accelerator")
> Reported-by: Richard Henderson <address@hidden>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
> tests/boot-serial-test.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
> index a8ca877168..b95c5e74ea 100644
> --- a/tests/boot-serial-test.c
> +++ b/tests/boot-serial-test.c
> @@ -78,7 +78,11 @@ static void test_machine(const void *data)
> fd = mkstemp(tmpname);
> g_assert(fd != -1);
>
> - args = g_strdup_printf("-M %s,accel=kvm:tcg "
> + /*
> + * Make sure that this test uses tcg if available: It is used as a
> + * fast-enough smoketest for that.
> + */
> + args = g_strdup_printf("-M %s,accel=tcg:kvm "
> "-chardev file,id=serial0,path=%s "
> "-no-shutdown -serial chardev:serial0 %s",
> test->machine, tmpname, test->extra);
>
Reviewed-by: Laurent Vivier <address@hidden>
- [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator, Cornelia Huck, 2017/08/16
- Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator,
Laurent Vivier <=
- Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator, Thomas Huth, 2017/08/16
- Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator, Paolo Bonzini, 2017/08/16
- Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator, Peter Maydell, 2017/08/16
- Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator, Cornelia Huck, 2017/08/16
- Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator, David Gibson, 2017/08/21
- Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator, Thomas Huth, 2017/08/22
- Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator, Peter Maydell, 2017/08/22
- Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator, Laurent Vivier, 2017/08/22
- Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator, Peter Maydell, 2017/08/22
- Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator, David Gibson, 2017/08/22