Re: [Qemu-devel] [PATCH v2] specs: Describe the TPM support in QEMU

[Laszlo Ersek]

On 08/16/17 10:33, Javier Martinez Canillas wrote:
> On 07/11/2017 09:36 PM, Laszlo Ersek wrote:
>> On 07/11/17 16:31, Stefan Berger wrote:
>>> This patch adds a description of the current TPM support in QEMU
>>> to the specs.
>>>
>>> Several public specs are referenced via their landing page on the
>>> trustedcomputinggroup.org website.
>>>
>>> Signed-off-by: Stefan Berger <address@hidden>
>>>
>>> ---
>>>
>>> v1->v2:
>>>   - fixed typos
>>>   - added command line for starting an x86_64 VM with TPM passthrough device
>>>   - added command lines for checks inside the VM
>>> ---
>>>  docs/specs/tpm.txt | 124 
>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 124 insertions(+)
>>>  create mode 100644 docs/specs/tpm.txt
>>
>> Awesome, thank you very much!
>>
>> I think I noticed one typo in new text:
>>
>>> +#> dmesg | grep TCPA
>>> +[    0.000000] ACPI: TCP 0x0000000003FFD191C 000032 (v02 BOCHS  \
>>> +    BXPCTCPA 0000001 BXPC 00000001)
>>
>> I think the prefix here should be "ACPI: TCPA"; the letter "A" probably
>> fell victim to wrapping the line nicely.
>>
>> Not sure which maintainer will pick up the patch, but I think they can
>> fix up this typo on their end (assuming no other reviewer asks for v3).
>>
>> Reviewed-by: Laszlo Ersek <address@hidden>
>>
> 
> It seems this patch was never picked.

Michael, can you pick this up please? (Asking you just based on the
output of "scripts/get_maintainer.pl -f docs/specs".)

This is a documentation-only patch (about existing code), so it can't
regress anything. It's been on the list for more than one month, so I
think it should be fine for 2.10.

Otherwise, should Stefan repost it when 2.11 is open (or whatever
version number will come next)?

Thanks,
Laszlo