Re: [Qemu-devel] [PATCH v3 0/5] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v3 0/5] target-ppc/spapr: Add FWNMI support in 
QEMU for PowerKVM guests
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0fa29fb816 ppc: spapr: Enable FWNMI capability
f6f423710e target/ppc: Handle NMI guest exit
966e015980 Wrapper function to wait on condition for the main loop mutex
3438e95e3b ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS 
calls
d00f1dcac0 ppc: spapr: Register and handle HCALL to receive updated RTAS region

=== OUTPUT BEGIN ===
Checking PATCH 1/5: ppc: spapr: Register and handle HCALL to receive updated 
RTAS region...
Checking PATCH 2/5: ppc: spapr: Handle "ibm, nmi-register" and "ibm, 
nmi-interlock" RTAS calls...
Checking PATCH 3/5: Wrapper function to wait on condition for the main loop 
mutex...
Checking PATCH 4/5: target/ppc: Handle NMI guest exit...
Checking PATCH 5/5: ppc: spapr: Enable FWNMI capability...
ERROR: externs should be avoided in .c files
#24: FILE: hw/ppc/spapr_rtas.c:50:
+extern int cap_fwnmi;

total: 1 errors, 0 warnings, 44 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden