Re: [Qemu-devel] [PATCH v6 1/3] Extend "info numa" with hotplugged memory information

[Eric Blake]

On 08/16/2017 06:06 AM, Vadim Galitsyn wrote:
> Report amount of hotplugged memory in addition to total
> amount per NUMA node.
> 

meta-comment: when sending a multi-patch series, it's best to include a
0/3 cover letter.  This, and more tips, are found at
http://wiki.qemu.org/Contribute/SubmitAPatch

> Signed-off-by: Vadim Galitsyn <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Cc: David Hildenbrand <address@hidden>
> Cc: address@hidden
> ---
>  include/qemu/typedefs.h |  1 +
>  include/sysemu/numa.h   |  7 ++++++-
>  monitor.c               |  9 ++++++---
>  numa.c                  | 18 +++++++++++++-----
>  4 files changed, 26 insertions(+), 9 deletions(-)
> 
> diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
> index 39bc835..e5f5347 100644
> --- a/include/qemu/typedefs.h
> +++ b/include/qemu/typedefs.h
> @@ -100,6 +100,7 @@ typedef struct uWireSlave uWireSlave;
>  typedef struct VirtIODevice VirtIODevice;
>  typedef struct Visitor Visitor;
>  typedef struct node_info NodeInfo;
> +typedef struct numa_node_mem NumaNodeMem;

Please follow HACKING naming conventions - name the struct NumaNodeMem
in all places (just because node_info didn't follow the rules doesn't
mean your addition should break them).  Also, this file should stay sorted.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature