[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/26] qapi: add 'if' condition on top-level sch
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/26] qapi: add 'if' condition on top-level schema elements |
|
Date: |
Thu, 17 Aug 2017 07:50:30 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Markus Armbruster <address@hidden> writes:
[...]
> Out of review brainpower for today. Hope to resume tomorrow.
>
> [...]
Nope, I'm giving up on this one. Please split it for reviewability.
Suggested split:
1. Preparatory refactoring for step 2, step by step
2. Frontend part: accept and check 'if', step by step
The accepted conditions should be visible in
tests/qapi-schema/qapi-schema-test.out.
3. Preparatory refactoring for step 4, step by step
4. Backend part: generate the ifdeffery, step by step
You already split off qapi2texi steps [PATCH 12-15]. Good. Perhaps
that's all that can be split off, perhaps not.
PATCH 08-11 may well profit from the same treatment.
Moving on to PATCH 16.