[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 for-2.11 06/10] target/s390x: introduce inter
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v1 for-2.11 06/10] target/s390x: introduce internal.h |
Date: |
Thu, 17 Aug 2017 13:59:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 17.08.2017 11:22, David Hildenbrand wrote:
> cpu.h should only contain what really has to be accessed outside of
> target/s390x/. Add internal.h which can only be used inside target/s390x/.
>
> Move everything that isn't fast enough to run away and restructure it
> right away. We'll move all kvm_* stuff later.
>
> Minor style fixes to avoid checkpatch warning to:
> - struct Lowcore: "{" goes into same line as typedef
> - struct LowCore: add spaces around "-" in array length calculations
> - time2tod() and tod2time(): move "{" to separate line
> - get_per_atmid(): add space between ")" and "?". Move cases by one char.
> - get_per_atmid(): drop extra paremthesis around (1 << 6)
>
> Change license of new file to GPL2+ and keep copyright notice.
>
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> target/s390x/arch_dump.c | 1 +
> target/s390x/cc_helper.c | 1 +
> target/s390x/cpu.c | 1 +
> target/s390x/cpu.h | 343 ---------------------------------------
> target/s390x/cpu_models.c | 1 +
> target/s390x/diag.c | 1 +
> target/s390x/excp_helper.c | 1 +
> target/s390x/fpu_helper.c | 1 +
> target/s390x/gdbstub.c | 1 +
> target/s390x/helper.c | 1 +
> target/s390x/int_helper.c | 1 +
> target/s390x/internal.h | 391
> +++++++++++++++++++++++++++++++++++++++++++++
> target/s390x/interrupt.c | 1 +
> target/s390x/ioinst.c | 1 +
> target/s390x/kvm.c | 1 +
> target/s390x/machine.c | 1 +
> target/s390x/mem_helper.c | 1 +
> target/s390x/misc_helper.c | 1 +
> target/s390x/mmu_helper.c | 1 +
> target/s390x/translate.c | 1 +
> 20 files changed, 409 insertions(+), 343 deletions(-)
> create mode 100644 target/s390x/internal.h
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v1 for-2.11 02/10] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c, (continued)
- [Qemu-devel] [PATCH v1 for-2.11 02/10] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c, David Hildenbrand, 2017/08/17
- [Qemu-devel] [PATCH v1 for-2.11 03/10] target/s390x: move psw_key_valid() to mem_helper.c, David Hildenbrand, 2017/08/17
- [Qemu-devel] [PATCH v1 for-2.11 04/10] target/s390x: move s390_do_cpu_reset() to diag.c, David Hildenbrand, 2017/08/17
- [Qemu-devel] [PATCH v1 for-2.11 05/10] target/s390x: move get_per_in_range() to misc_helper.c, David Hildenbrand, 2017/08/17
- [Qemu-devel] [PATCH v1 for-2.11 07/10] target/s390x: move a couple of functions to cpu.c, David Hildenbrand, 2017/08/17
- [Qemu-devel] [PATCH v1 for-2.11 06/10] target/s390x: introduce internal.h, David Hildenbrand, 2017/08/17
- Re: [Qemu-devel] [PATCH v1 for-2.11 06/10] target/s390x: introduce internal.h,
Thomas Huth <=
- [Qemu-devel] [PATCH v1 for-2.11 08/10] s390x: avoid calling kvm_ functions outside of target/s390x/, David Hildenbrand, 2017/08/17
- [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files, David Hildenbrand, 2017/08/17
- Message not available
- Message not available
- Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files, Thomas Huth, 2017/08/17
- Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files, Philippe Mathieu-Daudé, 2017/08/17
- Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files, Cornelia Huck, 2017/08/17
- Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files, David Hildenbrand, 2017/08/17
- Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files, Cornelia Huck, 2017/08/17
- Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files, David Hildenbrand, 2017/08/17
- Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files, Thomas Huth, 2017/08/17