qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v2 04/10] tests: Add vm test lib


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH RFC v2 04/10] tests: Add vm test lib
Date: Thu, 17 Aug 2017 14:25:33 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 17/08/2017 14:21, Stefan Hajnoczi wrote:
>> +        guest = QEMUMachine(binary=os.environ.get("QEMU", 
>> "qemu-system-x86_64"),
>> +                            args=args)
>> +        guest._vga = "std"
> _vga is a protected field.  We don't inherit from QEMUMachine so it
> shouldn't be accessed directly.  One option is to add a vga argument to
> the QEMUMachine() constructor.

You can just use "-device VGA" here, since this code is x86-specific.
"-vga none -device VGA" works well, so patch 2 can be dropped.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]