Re: [Qemu-devel] [RFC v4 08/13] ide: enumerate_slots implementation

[John Snow]

On 08/17/2017 12:54 AM, Markus Armbruster wrote:
> John Snow <address@hidden> writes:
> 
>> On 08/14/2017 05:57 PM, Eduardo Habkost wrote:
>>> Example output when using "-machine q35":
>>>
>>>   {
>>>     "available": true,
>>>     "count": 1,
>>>     "device-types": [
>>>       "ide-device"
>>>     ],
>>>     "hotpluggable": false,
>>>     "opts": [
>>>       { "option": "unit", "values": 0 },
>>>       { "option": "bus", "values": "ide.2" }
>>>     ],
>>>     "opts-complete": true
>>>   }
>>>   {
>>>     "available": false,
>>>     "count": 1,
>>>     "device": "/machine/unattached/device[19]",
>>>     "device-types": [
>>>       "ide-device"
>>>     ],
>>>     "hotpluggable": false,
>>>     "opts": [
>>>       { "option": "unit", "values": 1 },
>>>       { "option": "bus", "values": "ide.2" } ],
>>>     "opts-complete": true
>>>   }
>>>   {
>>>     "available": true,
>>>     "count": 10,
>>>     "device-types": [
>>>       "ide-device"
>>>     ],
>>>     "hotpluggable": false,
>>>     "opts": [
>>>       { "option": "unit", "values": [ [ 0, 1 ] ] },
>>
>> Hm, these unit values aren't really correct -- we do not support
>> primary/secondary semantics for IDE buses on the AHCI device. I guess
>> they technically exist, but you cannot use them for anything.
>>
>> Should I do something to "disable" or otherwise hide the unusable
>> secondary unit slots for AHCI devices?
> 
> I think that would make this introspection more useful.
> 

OK, let me look into how to meaningfully disable them. I didn't think
they were addressable in any tangible way currently, you certainly can't
put devices on them. I'm not sure where these values are coming from --
I'll play with the patches.

The only reason they even technically exist is because IDEBus comes
indelibly with two IDEStates baked in -- it can't be changed currently,
because everything's all wonky in IDE land.

I really ought to just rip off the bandaid and do an aggressive
refactoring ...... :|