Re: [Qemu-devel] [PATCH v5 5/6] block: add throttle block filter driver

[Manos Pitsidianakis]

On Fri, Aug 18, 2017 at 10:23:09AM +0200, Alberto Garcia wrote:
> On Fri 18 Aug 2017 05:10:18 AM CEST, Manos Pitsidianakis wrote:
> > block/throttle.c uses existing I/O throttle infrastructure inside a
> > block filter driver. I/O operations are intercepted in the filter's
> > read/write coroutines, and referred to block/throttle-groups.c
> >
> > The driver can be used with the syntax
> > -drive driver=throttle,file.filename=foo.qcow2, \
> >         limits.iops-total=...,throttle-group=bar
>
> I had understood that we would get rid of the limits.* options in this
> driver, or did I get it wrong?
>
> Other than that, the rest of the code looks perfect to me.
>
> Berto

I was going to send a patch after this was merged along with adding 
ThrottleGroups to the root container, to speed things up. Do you prefer 
to do this in this patch?

The root container patch probably has to go to the 'remove legacy' 
series since adding it here means the name collision errors introduce 
error paths in block/block-backend.c that go away in that series, and 
that'd be a waste of effort.

signature.asc
Description: PGP signature