[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 for-2.11 01/10] target/s390x: move cc_name()
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH v1 for-2.11 01/10] target/s390x: move cc_name() to cc_helper.c |
|
Date: |
Fri, 18 Aug 2017 12:04:14 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 18.08.2017 11:59, David Hildenbrand wrote:
> On 17.08.2017 11:22, David Hildenbrand wrote:
>> While at it, move the translations into the function.
>>
>> Signed-off-by: David Hildenbrand <address@hidden>
>> ---
>> target/s390x/cc_helper.c | 48
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>> target/s390x/cpu.h | 48
>> +-----------------------------------------------
>> 2 files changed, 49 insertions(+), 47 deletions(-)
[...]
> Just compiled with --disable-tcg
>
> s390_cpu_dump_state() needs cc_name. I suggest moving it to helper.c
> instead. Opinions?
Sounds fine to me, too.
Thomas