[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] s390x/tcg: specification exception for unknown
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH] s390x/tcg: specification exception for unknown diag |
|
Date: |
Fri, 18 Aug 2017 13:26:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 18.08.2017 13:00, Cornelia Huck wrote:
> While the PoP is silent on the issue, z/VM documentation states
> that unknown diagnose codes trigger a specification exception.
> We already do that when running with kvm, so change tcg to do so
> as well.
I just tried on a z/VM guest what happens if I call diag with an
unsupported code, and the Linux kernel then crashes with a specification
exception, indeed. So this sounds like the right thing to do!
> This is on top of "s390x: wire up diag288 in tcg".
May I suggest to order the patches the other way round? ... that's less
code churn that way.
Thomas