[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] QXL: always show default cursor, even for unsup
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH] QXL: always show default cursor, even for unsupported chunks |
Date: |
Fri, 18 Aug 2017 15:37:08 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
cc'ing in Gerd
* René Rebe (address@hidden) wrote:
> Hi,
>
> I was testing a Windows 10 guest with HiDPI scaling which
>
> actually made the cursor disappear and only multiple chunks
>
> warnings being printed.
>
> When the cursor is using currently unsupported multiple chunks, the
> builtin-left cursor is better than none.
>
> PS: if TB damages the white-space just let me know, only recently started
> using it, ...
>
> - René Rebe <address@hidden>
>
> diff -u -ur qemu-2.10.0-rc3/hw/display/qxl-render.c
> qemu-2.10.0-rc3-fixed/hw/display/qxl-render.c
> --- qemu-2.10.0-rc3/hw/display/qxl-render.c 2017-08-15 20:39:41.000000000
> +0200
> +++ qemu-2.10.0-rc3-fixed/hw/display/qxl-render.c 2017-08-17
> 13:42:37.108953910 +0200
> @@ -270,9 +270,10 @@
> }
> if (cursor->chunk.data_size != cursor->data_size) {
> fprintf(stderr, "%s: multiple chunks\n", __FUNCTION__);
> - return 1;
> + c = NULL; /* fall back to built-in left cursor */
> + } else {
> + c = qxl_cursor(qxl, cursor);
> }
> - c = qxl_cursor(qxl, cursor);
> if (c == NULL) {
> c = cursor_builtin_left_ptr();
> }
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK