[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/28] xtensa: replace cpu_xtensa_init() with cp
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH 18/28] xtensa: replace cpu_xtensa_init() with cpu_generic_init() |
|
Date: |
Fri, 18 Aug 2017 13:50:32 -0300 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, Aug 17, 2017 at 04:32:23PM +0200, Igor Mammedov wrote:
> On Wed, 16 Aug 2017 16:56:40 -0300
> Eduardo Habkost <address@hidden> wrote:
>
> > On Fri, Jul 14, 2017 at 03:52:09PM +0200, Igor Mammedov wrote:
> > > call xtensa_irq_init() at realize time which makes
> > > cpu_xtensa_init() like generic cpu creation function.
> > > As result we can replace it with cpu_generic_init()
> > > which does the same job, reducing code duplication a bit.
> > >
> > > Signed-off-by: Igor Mammedov <address@hidden>
> >
> > Looks good to me. Were you able to test it?
> images are from
> http://jcmvbkbc.spb.ru/~dumb/ws/osll/qemu-xtensa/20110829/xtensa-dc232b_kernel_rootfs.tgz
> http://jcmvbkbc.spb.ru/~dumb/tmp/201508231001/default-sim-fsf/Image.elf
>
> instructions to test is from
> http://qemu-buch.de/de/index.php?title=QEMU-KVM-Buch/_Gast-Systeme/_Xtensa-Architektur
>
> it boots till some point, so CPU is still there
> which should be sufficient for this patch
Thanks!
Reviewed-by: Eduardo Habkost <address@hidden>
--
Eduardo