Re: [Qemu-devel] [Qemu-block] [PATCH v5 08/13] tests: Rely more on global_qtest

[Paolo Bonzini]

On 18/08/2017 23:33, John Snow wrote:
>> Before the next few patches
>> get rid of the qtest_* layer, we first need to update the remaining
>> few spots that were using the long form where we can instead rely
>> on the short form.
>>
> Not a big fan of globals and implicit state, but I do at least agree
> that we don't need two sets of functions.

I agree with using the short form where possible, but I disagree on
removing the long forms.  Rather, global_qtest in my opinion should have
been static (though I'm not proposing that you do this); inlining the
wrappers is not needed for performance.

Paolo