[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 7/7] hw/ppc/spapr_iommu: Fix crash when removing the
From: |
David Gibson |
Subject: |
[Qemu-devel] [PULL 7/7] hw/ppc/spapr_iommu: Fix crash when removing the "spapr-tce-table" device |
Date: |
Tue, 22 Aug 2017 14:24:16 +1000 |
From: Thomas Huth <address@hidden>
QEMU currently aborts unexpectedly when the user tries to add and
remove a "spapr-tce-table" device:
$ qemu-system-ppc64 -nographic -S -nodefaults -monitor stdio
QEMU 2.9.92 monitor - type 'help' for more information
(qemu) device_add spapr-tce-table,id=x
(qemu) device_del x
**
ERROR:qemu/qdev-monitor.c:872:qdev_unplug: assertion failed: (hotplug_ctrl)
Aborted (core dumped)
The device should not be accessable for the users at all, it's just
used internally, so mark it with user_creatable = false.
Signed-off-by: Thomas Huth <address@hidden>
Signed-off-by: David Gibson <address@hidden>
---
hw/ppc/spapr_iommu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c
index e614621a83..ed2d53559a 100644
--- a/hw/ppc/spapr_iommu.c
+++ b/hw/ppc/spapr_iommu.c
@@ -618,6 +618,8 @@ static void spapr_tce_table_class_init(ObjectClass *klass,
void *data)
dc->init = spapr_tce_table_realize;
dc->reset = spapr_tce_reset;
dc->unrealize = spapr_tce_table_unrealize;
+ /* Reason: This is just an internal device for handling the hypercalls */
+ dc->user_creatable = false;
QLIST_INIT(&spapr_tce_tables);
--
2.13.5
- [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822, David Gibson, 2017/08/22
- [Qemu-devel] [PULL 3/7] ppc: fix ppc_set_compat() with KVM PR, David Gibson, 2017/08/22
- [Qemu-devel] [PULL 4/7] spapr: Allow configure-connector to be called multiple times, David Gibson, 2017/08/22
- [Qemu-devel] [PULL 5/7] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev', David Gibson, 2017/08/22
- [Qemu-devel] [PULL 2/7] target/ppc: 'PVR != host PVR' in KVM_SET_SREGS workaround, David Gibson, 2017/08/22
- [Qemu-devel] [PULL 1/7] boot-serial-test: prefer tcg accelerator, David Gibson, 2017/08/22
- [Qemu-devel] [PULL 7/7] hw/ppc/spapr_iommu: Fix crash when removing the "spapr-tce-table" device,
David Gibson <=
- [Qemu-devel] [PULL 6/7] hw/ppc/spapr_rtc: Mark the RTC device with user_creatable = false, David Gibson, 2017/08/22
- Re: [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822, Peter Maydell, 2017/08/22
- Re: [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822, Laurent Vivier, 2017/08/22
- Re: [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822, Peter Maydell, 2017/08/22
- Re: [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822, Laurent Vivier, 2017/08/22
- Re: [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822, Peter Maydell, 2017/08/22
- Re: [Qemu-devel] [Qemu-ppc] [PULL 0/7] ppc-for-2.10 queue 20170822, Daniel Henrique Barboza, 2017/08/22
- Re: [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170822, David Gibson, 2017/08/22