qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes
Date: Tue, 22 Aug 2017 07:19:45 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 08/22/2017 04:24 AM, Markus Armbruster wrote:
John Snow <address@hidden> writes:
[...]

Looks like all ten patches have an R-B despite changes; but it looks
like nothing particularly major was changed anyway.

Does this fall under Markus's jurisdiction?

(Well, except for qtest.py which seemingly has double-extra-no
maintainer...!)

qemu.py is about starting and controlling QEMU, commonly for testing
purposes.  It's related to QMP only by virtue of using QMP for control
(well, what else could it use?); if that makes me maintainer, I'll soon
maintain basically all tests :)

As far as I can tell, qemu.py's main user is still qemu-iotests, via
qtest.py.  Dan factored it out to make it available for
tests/migration/guestperf/.

Options for maintaining qemu.py and qtest.py:

* Maintain them with qemu-iotest

   Currently mainained with the block layer core, by Kevin and Max.

   - Keep it that way

   - Appoint qemu-iotest maintainer(s).

* Maintain them separately, say as "Python qtest support", appoint
   maintainer(s)

   Dan appears to be a hot contender:

     $ scripts/get_maintainer.pl -f --git-blame scripts/qtest.py
     Fam Zheng <address@hidden> (authored lines:71/110=65%,commits:1/3=33%)
     "Daniel P. Berrange" <address@hidden> (authored 
lines:39/110=35%,commits:2/3=67%)
     Max Reitz <address@hidden> (commits:2/3=67%)
     Amit Shah <address@hidden> (commits:1/3=33%)
     Stefan Hajnoczi <address@hidden> (commits:1/3=33%)
     address@hidden (open list:All patches CC here)
     $ scripts/get_maintainer.pl -f --git-blame scripts/qemu.py
     "Daniel P. Berrange" <address@hidden> (authored 
lines:217/229=95%,commits:2/4=50%)
     Eduardo Habkost <address@hidden> (authored 
lines:12/229=5%,commits:4/4=100%)
     Markus Armbruster <address@hidden> (commits:1/4=25%)
     Max Reitz <address@hidden> (commits:1/4=25%)
     Amit Shah <address@hidden> (commits:1/4=25%)
     address@hidden (open list:All patches CC here)

   Eduardo made the mistake^W^W^Wgraciously volunteered to maintain
   scripts/qmp/qmp-shell, which is also used for testing.  Perhaps he'd
   be willing to maintain these guys as well.

* Do nothing

   Hope "somebody" will take pity and merge patches.  A common value of
   "somebody" would be Paolo.

:'(

* Fam is also a good candidate for scripts/qemu.py with VM testing

* trivial queue?

* Add global Python maintainers

Mostly to review/merge...

Can we predict how the python scripts will evolve? Only fast-testing?

Is there some users hacking on qemu.py unaware they can/should use libvirt-python? If so, shouldn't we think about running more tests through libvirt and add effort there?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]