Re: [Qemu-devel] [PATCH v2 13/54] qapi: drop the sentinel in enum array

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> Now that all usages have been converted to user lookup helpers.

I don't think you got them all:

    $ git-grep -F _lookup.
    tests/test-qobject-input-visitor.c:    for (i = 0; i < EnumOne_lookup.size; 
i++) {
    tests/test-qobject-input-visitor.c:        v = 
visitor_input_test_init(data, "%s", EnumOne_lookup.array[i]);
    tests/test-qobject-input-visitor.c:                           
UserDefNativeListUnionKind_lookup.array[kind],
    tests/test-string-input-visitor.c:    for (i = 0; i < EnumOne_lookup.size; 
i++) {
    tests/test-string-input-visitor.c:        v = visitor_input_test_init(data, 
EnumOne_lookup.array[i]);
    ui/input-legacy.c:    for (i = 0; i < QKeyCode_lookup.size; i++) {
    ui/input-legacy.c:        if (!strncmp(key, QKeyCode_lookup.array[i], 
key_length) &&
    ui/input-legacy.c:            !QKeyCode_lookup.array[i][key_length]) {

I think I commented on all of these guys in my review of PATCH 06-12.