Re: [Qemu-devel] [PATCH 04/27] vhost-user-scsi: use g_strdup()

[Philippe Mathieu-Daudé]

On 08/23/2017 01:19 PM, Marc-André Lureau wrote:
> Since vhost-user-scsi uses glib.
>
> Signed-off-by: Marc-André Lureau <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>   contrib/vhost-user-scsi/vhost-user-scsi.c | 12 ++++--------
>   1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c 
> b/contrib/vhost-user-scsi/vhost-user-scsi.c
> index 78bcc65f5a..1fb57da2da 100644
> --- a/contrib/vhost-user-scsi/vhost-user-scsi.c
> +++ b/contrib/vhost-user-scsi/vhost-user-scsi.c
> @@ -822,10 +822,10 @@ int main(int argc, char **argv)
>           case 'h':
>               goto help;
>           case 'u':
> -            unix_fn = strdup(optarg);
> +            unix_fn = g_strdup(optarg);
>               break;
>           case 'i':
> -            iscsi_uri = strdup(optarg);
> +            iscsi_uri = g_strdup(optarg);
>               break;
>           default:
>               goto help;
> @@ -854,12 +854,8 @@ out:
>           vdev_scsi_deinit(vdev_scsi);
>           free(vdev_scsi);
>       }
> -    if (unix_fn) {
> -        free(unix_fn);
> -    }
> -    if (iscsi_uri) {
> -        free(iscsi_uri);
> -    }
> +    g_free(unix_fn);
> +    g_free(iscsi_uri);
>   
>       return err;
>