Re: [Qemu-devel] [PATCH v5 2/9] kvm: remove hard dependency on pci

[Cornelia Huck]

On Thu, 24 Aug 2017 03:13:46 +0200
Thomas Huth <address@hidden> wrote:

> On 23.08.2017 17:54, Cornelia Huck wrote:
> > The msi routing code in kvm calls some pci functions: provide
> > some stubs to enable builds without pci.
> > 
> > Also, to make this more obvious, guard them via a pci_available boolean
> > (which also can be reused in other places).
> > 
> > Fixes: e1d4fb2de ("kvm-irqchip: x86: add msi route notify fn")
> > Fixes: 767a554a0 ("kvm-all: Pass requester ID to MSI routing functions")
> > Reviewed-by: Pierre Morel <address@hidden>
> > Signed-off-by: Cornelia Huck <address@hidden>
> > ---
> >  accel/kvm/kvm-all.c  |  6 +++---
> >  hw/pci/pci-stub.c    | 16 +++++++++++++++-
> >  hw/pci/pci.c         |  2 ++
> >  include/hw/pci/pci.h |  2 ++
> >  4 files changed, 22 insertions(+), 4 deletions(-)

> > diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c
> > index ecad664946..2d3b32c6ab 100644
> > --- a/hw/pci/pci-stub.c
> > +++ b/hw/pci/pci-stub.c
> > @@ -23,10 +23,11 @@
> >  #include "monitor/monitor.h"
> >  #include "qapi/qmp/qerror.h"
> >  #include "hw/pci/pci.h"
> > -#include "qmp-commands.h"
> >  #include "hw/pci/msi.h"
> > +#include "qmp-commands.h"  
> 
> Nit: Unnecessary movement of the #include statement.

Seems to have slipped in during the various rebases. Fixed.

> 
> If you fix that:
> 
> Reviewed-by: Thomas Huth <address@hidden>

Thanks!