qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] qemu-iotests: improve nbd-fault-injector.py


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 2/3] qemu-iotests: improve nbd-fault-injector.py startup protocol
Date: Thu, 24 Aug 2017 12:39:43 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 08/24/2017 10:33 AM, Stefan Hajnoczi wrote:
> Currently 083 waits for the nbd-fault-injector.py server to start up by
> looping until netstat shows the TCP listen socket.
> 
> The startup protocol can be simplified by passing a 0 port number to
> nbd-fault-injector.py.  The kernel will allocate a port in bind(2) and
> the final port number can be printed by nbd-fault-injector.py.
> 
> This should make it slightly nicer and less TCP-specific to wait for
> server startup.  This patch changes nbd-fault-injector.py, the next one
> will rewrite server startup in 083.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  tests/qemu-iotests/nbd-fault-injector.py | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]