Re: [Qemu-devel] [PATCH v2 00/16] qapi-schema: Reorganize along maintenance boundaries

[Eric Blake]

On 08/24/2017 02:13 PM, Markus Armbruster wrote:
> Cc: "Daniel P. Berrange" <address@hidden>
> Cc: Alberto Garcia <address@hidden>
> Cc: Dr. David Alan Gilbert <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Jason Wang <address@hidden>
> Cc: Juan Quintela <address@hidden>
> Cc: Marc-André Lureau <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> 
> Much of the QAPI schema really belongs to a subsystem, but MAINTAINERS
> can't tell when it's all in a big ball of mud (qapi-schema.json) with
> a small ball of mud (event.json) on the side.
> 
> Create sub-schemas for the subsystems with the most substantial QAPI
> footprint in the mud.  The big ball shrinks by half, and the small
> ball goes away.
> 
> Bonus: the generated documentation's structure makes more sense now.
> It needs further improvement (see last patch), but it's a start.
> 
> I generally kept the order intact when moving source code.  It may be
> smarter to reorder it for improved legibility (both source and
> generated doc).  Subsystem maintainers, please tell me whether you'd
> like things reordered.

Ideally, moving from one file to another should be kept separate from
reordering within a file, to make review easier.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature