Re: [Qemu-devel] [PATCH 02/14] qlit: move qlit from check-qjson to qobject/

[Markus Armbruster]

Marc-André Lureau <address@hidden> writes:

> Fix code style issues while at it, to please check-patch.

It's spelled checkpatch.  Can touch up on commit.

> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  include/qapi/qmp/qlit.h | 49 +++++++++++++++++++++++++
>  qobject/qlit.c          | 89 +++++++++++++++++++++++++++++++++++++++++++++
>  tests/check-qjson.c     | 96 
> +------------------------------------------------
>  qobject/Makefile.objs   |  2 +-
>  4 files changed, 140 insertions(+), 96 deletions(-)
>  create mode 100644 include/qapi/qmp/qlit.h
>  create mode 100644 qobject/qlit.c
>
> diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h
> new file mode 100644
> index 0000000000..4e2e760ef1
> --- /dev/null
> +++ b/include/qapi/qmp/qlit.h
> @@ -0,0 +1,49 @@
> +/*
> + * Copyright IBM, Corp. 2009
> + * Copyright (c) 2013, 2015, 2017 Red Hat Inc.
> + *
> + * Authors:
> + *  Anthony Liguori   <address@hidden>
> + *  Markus Armbruster <address@hidden>
> + *  Marc-André Lureau <address@hidden>
> + *
> + * This work is licensed under the terms of the GNU LGPL, version 2.1 or 
> later.
> + * See the COPYING.LIB file in the top-level directory.
> + *
> + */
> +#ifndef QLIT_H_
> +#define QLIT_H_

QLIT_H (no trailing _), to match the other headers in this directory.
Can touch up on commit.

[...]

With the two spelling nits corrected:
Reviewed-by: Markus Armbruster <address@hidden>