[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] wrong ioctl error handling on dirty pages sync?
From: |
Ján Poctavek |
Subject: |
[Qemu-devel] wrong ioctl error handling on dirty pages sync? |
Date: |
Fri, 25 Aug 2017 13:42:55 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
Hi guys,
Maybe it is just my lack of understanding, this seems like a bug to me:
To get list of dirty pages, qemu calls kvm_vm_ioctl() with
KVM_GET_DIRTY_LOG:
https://github.com/qemu/qemu/blob/v2.10.0-rc4/accel/kvm/kvm-all.c#L494
and considers the ioctl call failed when -1 is returned.
But the kvm_vm_ioctl() itself returns -errno, not the -1 on error:
https://github.com/qemu/qemu/blob/v2.10.0-rc4/accel/kvm/kvm-all.c#L2142
Thanks in advance for sheding some light into this for me.
Jan
- [Qemu-devel] wrong ioctl error handling on dirty pages sync?,
Ján Poctavek <=