Re: [Qemu-devel] [PATCH 2/3] Test for full Backup

[John Snow]

On 08/25/2017 10:36 AM, Peter Maydell wrote:
> On 23 August 2017 at 14:04, Ishani Chugh
> <address@hidden> wrote:
>> This patch is the test for full backup implementation in Backup tool.
>> The test employs two basic substests:
>> 1) Backing up an empty guest and comparing it with base image.
>> 2) Writing a pattern to the guest, creating backup and comparing
>>    with the base image.
>>
>> Signed-off-by: Ishani Chugh <address@hidden>
>> ---
>>  tests/qemu-iotests/191     | 78 
>> ++++++++++++++++++++++++++++++++++++++++++++++
>>  tests/qemu-iotests/191.out | 33 ++++++++++++++++++++
>>  tests/qemu-iotests/group   |  1 +
>>  3 files changed, 112 insertions(+)
>>  create mode 100755 tests/qemu-iotests/191
>>  create mode 100644 tests/qemu-iotests/191.out
>>
>> diff --git a/tests/qemu-iotests/191 b/tests/qemu-iotests/191
>> new file mode 100755
>> index 0000000..fb4cde9
>> --- /dev/null
>> +++ b/tests/qemu-iotests/191
>> @@ -0,0 +1,78 @@
>> +#!/bin/bash
>> +#
>> +# Test full backup functionality of qemu-backup tool
>> +#
>> +# Copyright (C) 2009 Red Hat, Inc.
> 
> Should this perhaps have a different copyright owner and date?
> 
> thanks
> -- PMM
> 
Yes!

Ishani, please take credit for your own work! :)