[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] migration: Reset rather than destroy main_t
|
From: |
Peter Xu |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] migration: Reset rather than destroy main_thread_load_event |
|
Date: |
Mon, 28 Aug 2017 17:01:26 +0800 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Aug 25, 2017 at 04:51:29PM +0100, Dr. David Alan Gilbert wrote:
[...]
> > PS, in migration_incoming_get_current() we do
> > mis_current.state = MIGRATION_STATUS_NONE;
> > memset(&mis_current, 0, sizeof(MigrationIncomingState));
> >
> > and the first line there is pointless because the memset
> > blasts zeroes over it anyway.
>
> Hmm yes.
I'll include this cleanup within my (future) patch to init incoming
migration object in migration_object_init() as well. Thanks,
--
Peter Xu