[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] tests: Make acpid test compile
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] tests: Make acpid test compile |
Date: |
Wed, 30 Aug 2017 12:51:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Cedric Le Goater <address@hidden> wrote:
> On 08/23/2017 01:53 PM, Dr. David Alan Gilbert wrote:
>> * Juan Quintela (address@hidden) wrote:
>>> Compiler gets confused with the size of the struct, so move form
>>> g_new0() to g_malloc0().
>>>
>>> I *think* that the problem is in gcc (or glib for that matter), but
>>> the documentation of the g_new0 states that 1sts first argument is an
>>> struct type, and uint32_t is not an struct type.
>>>
>>> Signed-off-by: Juan Quintela <address@hidden>
>>> ---
>>> tests/vmgenid-test.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/vmgenid-test.c b/tests/vmgenid-test.c
>>> index 3d5c1c3615..032e1d465a 100644
>>> --- a/tests/vmgenid-test.c
>>> +++ b/tests/vmgenid-test.c
>>> @@ -67,7 +67,7 @@ static uint32_t acpi_find_vgia(void)
>>> g_assert_cmpint(tables_nr, >, 0);
>>>
>>> /* get the addresses of the tables pointed by rsdt */
>>> - tables = g_new0(uint32_t, tables_nr);
>>> + tables = g_malloc0(sizeof(uint32_t) * tables_nr);
>>
>> I think there's an easier fix for this I think;
>> try:
>>
>> - g_assert_cmpint(tables_nr, >, 0);
>> + g_assert(tables_nr > 0);
I liked more the following one.
>
> I fixed that one with :
>
> @@ -40,7 +40,7 @@ static uint32_t acpi_find_vgia(void)
> AcpiRsdpDescriptor rsdp_table;
> uint32_t rsdt;
> AcpiRsdtDescriptorRev1 rsdt_table;
> - int tables_nr;
> + uint32_t tables_nr;
> uint32_t *tables;
> AcpiTableHeader ssdt_table;
> VgidTable vgid_table;
This make things work for me, so moving to this one.
Thanks, Juan.
[Qemu-devel] [PATCH 1/2] tests: Use real size for iov tests, Juan Quintela, 2017/08/23