Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non implemented cpu models

[Thomas Huth]

On 30.08.2017 15:24, Igor Mammedov wrote:
> Remove cpu models that aren't implemented and are not
> compiled/tested since they are under TODO ifdef
> which isn't defined in sources.
> 
> If someone really needs a removed model he/she should add
> as regular one with corresponding implementation.
> 
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  target/ppc/cpu-models.c | 459 
> ------------------------------------------------
>  1 file changed, 459 deletions(-)
> 
> diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c
> index cf878a9..611fc1b 100644
> --- a/target/ppc/cpu-models.c
> +++ b/target/ppc/cpu-models.c
> @@ -19,11 +19,6 @@
>   * License along with this library; if not, see 
> <http://www.gnu.org/licenses/>.
>   */
[...]
>      /* PowerPC 440 family                                                    
> */
> -#if defined(TODO_USER_ONLY)
> -    POWERPC_DEF("440",           CPU_POWERPC_440,                    440GP,
> -                "Generic PowerPC 440")
> -#endif

Please don't remove this TODO_USER_ONLY entry. It's still used if the
code is compiled with CONFIG_USER_ONLY.

 Thomas