[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/8] tcg/s390 improvements
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 0/8] tcg/s390 improvements |
Date: |
Wed, 30 Aug 2017 18:18:10 +0200 |
On Wed, 30 Aug 2017 13:14:03 +0200
Cornelia Huck <address@hidden> wrote:
> On Tue, 29 Aug 2017 13:47:51 -0700
> Richard Henderson <address@hidden> wrote:
>
> > This finally converts s390 to the tcg_target_op_def function, which
> > allows constraints to vary at runtime. Once we have that, we can
> >
> > (1) Perform some facilities checks once during startup instead of
> > every time we evaluate the constraint,
> > (2) Use the distinct-operands facility from z196.
> >
> > In addition, two cleanups to the setcond expansion
> >
> > (3) Use the load-on-condition-2 facility from z13,
> > (4) Use a smaller expansion for LE/LEU using SLBGR.
> >
> > I wrote these after soft freeze and before I changed jobs, so it has
> > seen some testing. Unfortunately, I no longer have access to s390
> > hardware, so I'd appreciate it if someone could re-test this rebase.
>
> FWIW, this passes my smoketests.
>
> Looking at the patches now...
That might have been a mistake :)
The parts that I managed to at least superficially understand looked
fine, though; so feel free to add
Acked-by: Cornelia Huck <address@hidden>
- Re: [Qemu-devel] [PATCH 1/8] tcg/s390: Fully convert tcg_target_op_def, (continued)
- [Qemu-devel] [PATCH 2/8] tcg/s390: Merge cmpi facilities check to tcg_target_op_def, Richard Henderson, 2017/08/29
- [Qemu-devel] [PATCH 3/8] tcg/s390: Merge muli facilities check to tcg_target_op_def, Richard Henderson, 2017/08/29
- [Qemu-devel] [PATCH 4/8] tcg/s390: Merge add2i facilities check to tcg_target_op_def, Richard Henderson, 2017/08/29
- [Qemu-devel] [PATCH 5/8] tcg/s390: Merge ori+xori facilities check to tcg_target_op_def, Richard Henderson, 2017/08/29
- [Qemu-devel] [PATCH 6/8] tcg/s390: Use distinct-operands facility, Richard Henderson, 2017/08/29
- [Qemu-devel] [PATCH 8/8] tcg/s390: Use slbgr for setcond le and leu, Richard Henderson, 2017/08/29
- [Qemu-devel] [PATCH 7/8] tcg/s390: Use load-on-condition-2 facility, Richard Henderson, 2017/08/29
- Re: [Qemu-devel] [PATCH 0/8] tcg/s390 improvements, no-reply, 2017/08/29
- Re: [Qemu-devel] [PATCH 0/8] tcg/s390 improvements, Cornelia Huck, 2017/08/30
- Re: [Qemu-devel] [PATCH 0/8] tcg/s390 improvements,
Cornelia Huck <=