[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 42/44] s390-ccw: Fix alignment for CCW1
From: |
Cornelia Huck |
Subject: |
[Qemu-devel] [PULL 42/44] s390-ccw: Fix alignment for CCW1 |
Date: |
Wed, 30 Aug 2017 18:52:50 +0200 |
From: Farhan Ali <address@hidden>
The commit 198c0d1f9df8c4 s390x/css: check ccw address validity
exposes an alignment issue in ccw bios.
According to PoP the CCW must be doubleword aligned. Let's fix
this in the bios.
Cc: address@hidden
Signed-off-by: Farhan Ali <address@hidden>
Reviewed-by: Halil Pasic <address@hidden>
Reviewed-by: Eric Farman <address@hidden>
Acked-by: Christian Borntraeger <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
pc-bios/s390-ccw/cio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/cio.h b/pc-bios/s390-ccw/cio.h
index f5b4549ea3..55eaeee4b6 100644
--- a/pc-bios/s390-ccw/cio.h
+++ b/pc-bios/s390-ccw/cio.h
@@ -133,7 +133,7 @@ struct ccw1 {
__u8 flags;
__u16 count;
__u32 cda;
-} __attribute__ ((packed));
+} __attribute__ ((packed, aligned(8)));
#define CCW_FLAG_DC 0x80
#define CCW_FLAG_CC 0x40
--
2.13.5
- [Qemu-devel] [PULL 32/44] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c, (continued)
- [Qemu-devel] [PULL 32/44] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c, Cornelia Huck, 2017/08/30
- [Qemu-devel] [PULL 31/44] target/s390x: move cc_name() to helper.c, Cornelia Huck, 2017/08/30
- [Qemu-devel] [PULL 33/44] target/s390x: move psw_key_valid() to mem_helper.c, Cornelia Huck, 2017/08/30
- [Qemu-devel] [PULL 34/44] target/s390x: move s390_do_cpu_reset() to diag.c, Cornelia Huck, 2017/08/30
- [Qemu-devel] [PULL 35/44] target/s390x: move get_per_in_range() to misc_helper.c, Cornelia Huck, 2017/08/30
- [Qemu-devel] [PULL 36/44] target/s390x: introduce internal.h, Cornelia Huck, 2017/08/30
- [Qemu-devel] [PULL 38/44] s390x: avoid calling kvm_ functions outside of target/s390x/, Cornelia Huck, 2017/08/30
- [Qemu-devel] [PULL 37/44] target/s390x: move a couple of functions to cpu.c, Cornelia Huck, 2017/08/30
- [Qemu-devel] [PULL 39/44] s390x/kvm: move KVM declarations and stubs to separate files, Cornelia Huck, 2017/08/30
- [Qemu-devel] [PULL 41/44] s390x/s390-stattrib: Mark the storage attribute as not user_creatable, Cornelia Huck, 2017/08/30
- [Qemu-devel] [PULL 42/44] s390-ccw: Fix alignment for CCW1,
Cornelia Huck <=
- [Qemu-devel] [PULL 40/44] target/s390x: cleanup cpu.h, Cornelia Huck, 2017/08/30
- [Qemu-devel] [PULL 44/44] s390x/pci: fixup trap_msix(), Cornelia Huck, 2017/08/30
- [Qemu-devel] [PULL 43/44] pc-bios/s390-ccw.img: update image, Cornelia Huck, 2017/08/30
- Re: [Qemu-devel] [PULL 00/44] first batch of s390x patches for 2.11, Peter Maydell, 2017/08/31