[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 11/29] vnc: use DIV_ROUND_UP
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PULL 11/29] vnc: use DIV_ROUND_UP |
Date: |
Thu, 31 Aug 2017 12:34:14 +0200 |
I used the clang-tidy qemu-round check to generate the fix:
https://github.com/elmarco/clang-tools-extra
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
---
ui/vnc-enc-tight.c | 2 +-
ui/vnc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 89ab12c0d8..f38aceb4da 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -979,7 +979,7 @@ static int send_mono_rect(VncState *vs, int x, int y,
}
#endif
- bytes = ((w + 7) / 8) * h;
+ bytes = (DIV_ROUND_UP(w, 8)) * h;
vnc_write_u8(vs, (stream | VNC_TIGHT_EXPLICIT_FILTER) << 4);
vnc_write_u8(vs, VNC_TIGHT_FILTER_PALETTE);
diff --git a/ui/vnc.c b/ui/vnc.c
index 2c1c0cb5ed..fd43f9b983 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -2781,7 +2781,7 @@ static int vnc_refresh_server_surface(VncDisplay *vd)
PIXMAN_FORMAT_BPP(pixman_image_get_format(vd->guest.fb));
guest_row0 = (uint8_t *)pixman_image_get_data(vd->guest.fb);
guest_stride = pixman_image_get_stride(vd->guest.fb);
- guest_ll = pixman_image_get_width(vd->guest.fb) * ((guest_bpp + 7) /
8);
+ guest_ll = pixman_image_get_width(vd->guest.fb) *
(DIV_ROUND_UP(guest_bpp, 8));
}
line_bytes = MIN(server_stride, guest_ll);
--
2.14.1.146.gd35faa819
- [Qemu-devel] [PULL 00/29] Code cleanup patches, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 01/29] i386: use ROUND_UP macro, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 02/29] vnc: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 03/29] vhdx: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 04/29] vhost: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 05/29] i8254: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 06/29] pcspk: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 07/29] dmg: use DIV_ROUND_UP, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 08/29] qcow2: use DIV_ROUND_UP, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 10/29] vvfat: use DIV_ROUND_UP, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 11/29] vnc: use DIV_ROUND_UP,
Marc-André Lureau <=
- [Qemu-devel] [PULL 09/29] vpc: use DIV_ROUND_UP, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 12/29] ui: use DIV_ROUND_UP, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 13/29] vga: use DIV_ROUND_UP, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 15/29] monitor: use DIV_ROUND_UP, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 14/29] virtio-gpu: use DIV_ROUND_UP, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 16/29] console: use DIV_ROUND_UP, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 17/29] virtio-serial: use DIV_ROUND_UP, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 18/29] piix: use DIV_ROUND_UP, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 20/29] usb-hub: use DIV_ROUND_UP, Marc-André Lureau, 2017/08/31
- [Qemu-devel] [PULL 19/29] q35: use DIV_ROUND_UP, Marc-André Lureau, 2017/08/31