Re: [Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to s390-virtio-hcall.h

[Thomas Huth]

On 31.08.2017 15:18, David Hildenbrand wrote:
> On 31.08.2017 11:29, Thomas Huth wrote:
>> On 30.08.2017 19:05, David Hildenbrand wrote:
>>> The only interface left, so let's properly rename it.
>>>
>>> Signed-off-by: David Hildenbrand <address@hidden>
>>> ---
>>>  hw/s390x/s390-virtio-ccw.c                      | 2 +-
>>>  hw/s390x/s390-virtio-hcall.c                    | 2 +-
>>>  hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} | 2 +-
>>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>>  rename hw/s390x/{s390-virtio.h => s390-virtio-hcall.h} (92%)
>> [...]
>>> diff --git a/hw/s390x/s390-virtio.h b/hw/s390x/s390-virtio-hcall.h
>>> similarity index 92%
>>> rename from hw/s390x/s390-virtio.h
>>> rename to hw/s390x/s390-virtio-hcall.h
>>> index d984cd4115..64c5bbd827 100644
>>> --- a/hw/s390x/s390-virtio.h
>>> +++ b/hw/s390x/s390-virtio-hcall.h
>>> @@ -1,5 +1,5 @@
>>>  /*
>>> - * Virtio interfaces for s390
>>> + * Support for virtio hypercalls on s390x
>>>   *
>>>   * Copyright 2012 IBM Corp.
>>>   * Author(s): Cornelia Huck <address@hidden>
>>>
>>
>> Maybe also rename the HW_S390_VIRTIO_H header guard? Anyway:
>>
>> Reviewed-by: Thomas Huth <address@hidden>
>>
> 
> Sure, will do. Is HW_S390_VIRTIO_HCALL_H okay?

Sounds fine.

 Thomas