qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 02/11] cpu: drop old comments describing memb


From: Cornelia Huck
Subject: Re: [Qemu-devel] [PATCH v1 02/11] cpu: drop old comments describing members
Date: Thu, 31 Aug 2017 16:23:02 +0200

On Wed, 30 Aug 2017 19:05:52 +0200
David Hildenbrand <address@hidden> wrote:

> These comments are obviously stale.
> 
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  include/qom/cpu.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/qom/cpu.h b/include/qom/cpu.h
> index 25eefea7ab..6b4b838e8f 100644
> --- a/include/qom/cpu.h
> +++ b/include/qom/cpu.h
> @@ -378,10 +378,10 @@ struct CPUState {
>      DECLARE_BITMAP(trace_dstate, CPU_TRACE_DSTATE_MAX_EVENTS);
>  
>      /* TODO Move common fields from CPUArchState here. */
> -    int cpu_index; /* used by alpha TCG */
> -    uint32_t halted; /* used by alpha, cris, ppc TCG */
> +    int cpu_index;
> +    uint32_t halted;
>      uint32_t can_do_io;
> -    int32_t exception_index; /* used by m68k TCG */
> +    int32_t exception_index;
>  
>      /* shared by kvm, hax and hvf */
>      bool vcpu_dirty;

Yup, no need to drag these around. In case I don't take this through
s390-next:

Acked-by: Cornelia Huck <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]