[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 05/13] qemu.py: include debug information on laun
From: |
Amador Pahim |
Subject: |
[Qemu-devel] [PATCH v8 05/13] qemu.py: include debug information on launch error |
Date: |
Fri, 1 Sep 2017 13:28:21 +0200 |
When launching a VM, if an exception happens and the VM is not
initiated, it might be useful to see the qemu command line and
the qemu command output.
This patch creates that message. Notice that self._iolog needs to be
cleaned up in the beginning of the launch() to make sure we will not
expose the qemu log from a previous launch if the current one fails.
Signed-off-by: Amador Pahim <address@hidden>
---
scripts/qemu.py | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 670c048569..3ebe5ee0a4 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -141,6 +141,7 @@ class QEMUMachine(object):
def launch(self):
'''Launch the VM and establish a QMP connection'''
+ self._iolog = None
self._qemu_full_args = None
devnull = open(os.path.devnull, 'rb')
qemulog = open(self._qemu_log_path, 'wb')
@@ -160,6 +161,12 @@ class QEMUMachine(object):
self._popen.wait()
self._load_io_log()
self._post_shutdown()
+
+ LOG.debug('Error launching VM')
+ if self._qemu_full_args:
+ LOG.debug('Command: %r', ' '.join(self._qemu_full_args))
+ if self._iolog:
+ LOG.debug('Output: %r', self._iolog)
raise
def shutdown(self):
--
2.13.5
- Re: [Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code, (continued)
[Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/09/01
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Fam Zheng, 2017/09/04
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/09/14
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Eduardo Habkost, 2017/09/14
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/09/14
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Eduardo Habkost, 2017/09/14
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/09/14
[Qemu-devel] [PATCH v8 05/13] qemu.py: include debug information on launch error,
Amador Pahim <=
[Qemu-devel] [PATCH v8 07/13] qemu.py: close _qemu_log_path on cleanup, Amador Pahim, 2017/09/01
[Qemu-devel] [PATCH v8 09/13] qemu.py: always cleanup on shutdown(), Amador Pahim, 2017/09/01
[Qemu-devel] [PATCH v8 08/13] qemu.py: refactor launch(), Amador Pahim, 2017/09/01
[Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of 'returncode', Amador Pahim, 2017/09/01
[Qemu-devel] [PATCH v8 11/13] qemu.py: cleanup redundant calls in launch(), Amador Pahim, 2017/09/01