Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling

[Alberto Garcia]

On Mon 04 Sep 2017 06:07:47 PM CEST, Pradeep Jagadeesh wrote:

> +void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict)
> +{
> +    Error *err = NULL;
> +    IOThrottleList *fsdev_list, *info;
> +    fsdev_list = qmp_query_fsdev_io_throttle(&err);
> +
> +    for (info = fsdev_list; info; info = info->next) {
> +        print_fsdev_throttle_config(mon, info->value);
> +    }
> +    qapi_free_IOThrottleList(fsdev_list);
> +}

You're passing an Error to qmp_query_fsdev_io_throttle() but then you
don't handle it. Use hmp_handle_error() as I said in my previous e-mail.

I know that with the current code qmp_query_fsdev_io_throttle() is never
going to fail, but that's no reason to declare an Error and then ignore
it.

Berto