Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions"

[Juan Quintela]

Eric Blake <address@hidden> wrote:
> On 09/06/2017 06:51 AM, Juan Quintela wrote:
>> This reverts commit d4622e55883211072621958d39ddaa73483d201e.
>
> But with no reason why?  What bugs are you fixing by reverting this?

I put it on the cover letter.  I am investigating *why* it fails on me.
It got the thread handed.

>
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>>  include/io/channel.h       |  90 ---------------------------------------
>>  io/channel.c               |  94 -----------------------------------------
>>  tests/io-channel-helpers.c | 102 
>> +++++++++++++++++++++++++++++++++++++++++----
>>  3 files changed, 93 insertions(+), 193 deletions(-)
>>
>
> Looking ahead, I see 8/22 recreates qio_channel_readv_all (but not
> qio_channel_read_all); how does that differ from this one?
>
> Should you be squashing 1/22 and 8/22 into a single non-revert patch
> that just fixes bugs on top of what is already in the tree?

My plan is to fix whatever is there and see why it is failing.

> Also, have you seen my patches, that also fix bugs in the _all functions?
> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01053.html

No, I have to take a look, thanks.

Thanks, Juan.