[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 0/7] Proof of concept to power up "make test
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH RFC 0/7] Proof of concept to power up "make test" with docker |
Date: |
Fri, 8 Sep 2017 02:26:21 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH RFC 0/7] Proof of concept to power up "make test"
with docker
Message-id: address@hidden
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
t [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0c7a642a86 tests: Move i386 tcg tests to check-tcg
44226ca4fd buildsys: Add "check-tcg" target
e670c4e114 tests: Build fix for linux-test
09fbbd7842 tests: Build fix for hello-i386
0546399a8a docker: Add fedora-i386-cross image
5a8cd21a02 docker: Add "cc" subcommand
89d4346f6e Makefile: Rename TARGET_DIRS to TARGET_LIST
=== OUTPUT BEGIN ===
Checking PATCH 1/7: Makefile: Rename TARGET_DIRS to TARGET_LIST...
Checking PATCH 2/7: docker: Add "cc" subcommand...
Checking PATCH 3/7: docker: Add fedora-i386-cross image...
Checking PATCH 4/7: tests: Build fix for hello-i386...
ERROR: externs should be avoided in .c files
#20: FILE: tests/tcg/hello-i386.c:23:
+void _start(void);
total: 1 errors, 0 warnings, 7 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/7: tests: Build fix for linux-test...
ERROR: if this code is redundant consider removing it
#141: FILE: tests/tcg/linux-test.c:326:
+#if 0
total: 1 errors, 0 warnings, 179 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/7: buildsys: Add "check-tcg" target...
Checking PATCH 7/7: tests: Move i386 tcg tests to check-tcg...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH RFC 0/7] Proof of concept to power up "make test" with docker, Fam Zheng, 2017/09/08
- [Qemu-devel] [PATCH RFC 1/7] Makefile: Rename TARGET_DIRS to TARGET_LIST, Fam Zheng, 2017/09/08
- [Qemu-devel] [PATCH RFC 2/7] docker: Add "cc" subcommand, Fam Zheng, 2017/09/08
- [Qemu-devel] [PATCH RFC 3/7] docker: Add fedora-i386-cross image, Fam Zheng, 2017/09/08
- [Qemu-devel] [PATCH RFC 4/7] tests: Build fix for hello-i386, Fam Zheng, 2017/09/08
- [Qemu-devel] [PATCH RFC 5/7] tests: Build fix for linux-test, Fam Zheng, 2017/09/08
- [Qemu-devel] [PATCH RFC 6/7] buildsys: Add "check-tcg" target, Fam Zheng, 2017/09/08
- [Qemu-devel] [PATCH RFC 7/7] tests: Move i386 tcg tests to check-tcg, Fam Zheng, 2017/09/08
- Re: [Qemu-devel] [PATCH RFC 0/7] Proof of concept to power up "make test" with docker,
no-reply <=