Re: [Qemu-devel] [PATCH 2/2] hw/pcie: disable IO port fwd by default for pcie-root-port

[Marcel Apfelbaum]

On 06/09/2017 17:49, Eduardo Habkost wrote:
> On Wed, Sep 06, 2017 at 05:26:58PM +0300, Marcel Apfelbaum wrote:
> > For most cases the devices attached to PCIe Root Ports
> > do not need IO ports range, add an 'enable-io-fwd' property
> > making it false by default, but keeping it true for older machines.
> >
> > Signed-off-by: Marcel Apfelbaum <address@hidden>
> [...]
> > @@ -78,6 +111,7 @@ static const VMStateDescription vmstate_rp_dev = {
> >   
> >   static Property gen_rp_props[] = {
> >       DEFINE_PROP_BOOL("x-migrate-msix", GenPCIERootPort, migrate_msix, true),
> > +    DEFINE_PROP_BOOL("enable-io-fwd", GenPCIERootPort, enable_io_fwd, false),

Hi Eduardo,

> There's no "x-" prefix, so I guess we really need to let the user
> or management software to set enable-io-fwd=on explicitly on some
> cases?

Definitely. Specifically 2 cases:
 - attach PCIe-PCI bridge to start a legacy PCI hierarchy.
 - assign a device requiring IO ports range.

Thanks,
Marcel