Re: [Qemu-devel] [PATCH v2 0/3] Improve websock response / error handling

[Daniel P. Berrange]

On Fri, Sep 08, 2017 at 03:53:57AM -0700, address@hidden wrote:
> /tmp/qemu-test/src/io/channel-websock.c: In function 
> ‘qio_channel_websock_date_str’:
> /tmp/qemu-test/src/io/channel-websock.c:171: error: ‘GTimeZone’ undeclared 
> (first use in this function)
> /tmp/qemu-test/src/io/channel-websock.c:171: error: (Each undeclared 
> identifier is reported only once
> /tmp/qemu-test/src/io/channel-websock.c:171: error: for each function it 
> appears in.)
> /tmp/qemu-test/src/io/channel-websock.c:171: error: ‘utc’ undeclared (first 
> use in this function)
> /tmp/qemu-test/src/io/channel-websock.c:171: warning: implicit declaration of 
> function ‘g_time_zone_new_utc’
> /tmp/qemu-test/src/io/channel-websock.c:171: warning: nested extern 
> declaration of ‘g_time_zone_new_utc’
> /tmp/qemu-test/src/io/channel-websock.c:172: error: ‘GDateTime’ undeclared 
> (first use in this function)
> /tmp/qemu-test/src/io/channel-websock.c:172: error: ‘now’ undeclared (first 
> use in this function)
> /tmp/qemu-test/src/io/channel-websock.c:172: warning: implicit declaration of 
> function ‘g_date_time_new_now’
> /tmp/qemu-test/src/io/channel-websock.c:172: warning: nested extern 
> declaration of ‘g_date_time_new_now’
> /tmp/qemu-test/src/io/channel-websock.c:173: warning: implicit declaration of 
> function ‘g_date_time_format’
> /tmp/qemu-test/src/io/channel-websock.c:173: warning: nested extern 
> declaration of ‘g_date_time_format’
> /tmp/qemu-test/src/io/channel-websock.c:175: warning: implicit declaration of 
> function ‘g_date_time_unref’
> /tmp/qemu-test/src/io/channel-websock.c:175: warning: nested extern 
> declaration of ‘g_date_time_unref’
> /tmp/qemu-test/src/io/channel-websock.c:176: warning: implicit declaration of 
> function ‘g_time_zone_unref’
> /tmp/qemu-test/src/io/channel-websock.c:176: warning: nested extern 
> declaration of ‘g_time_zone_unref’

Urgh,  GTimeZone arrived in glib 2.26 and we hav 2.22 as the min :-(

I'll have to switch to strftime....

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|